Remove fullname from helm chart since nothing uses it #2242
Conversation
Signed-off-by: Daniel Valdivia <[email protected]>
dvaldivia
requested review from
pjuarezd,
cniackz,
shtripat,
cesnietor,
jiuker and
allanrogerr
There was a problem hiding this comment.
I checked the code if we really need this name to be fixed, but there are not a lot of places where we need this name to be fixed. The controller.getOperatorDeploymentName() function looks like this (source):
func getOperatorDeploymentName() string {
// NOTE: constants expanded for clarity in this PR
return env.Get("MINIO_OPERATOR_DEPLOYMENT_NAME", "minio-operator")
}I don't think this name needs to be fixed, if we also set the MINIO_OPERATOR_DEPLOYMENT_NAME environment variable properly and set the name here. According to the documentation this is a support scenario (that probably doesn't work properly anymore for a while). It should be tested though.
It's fine by me to hardcode the name, but then we should remove this environment variable from code and update the documentation too.
@dvaldivia ^^ |
|
@dvaldivia I think we should remove the environment variable if we decide to use a fixed name. That's why I didn't approve this change. I'ld be happy to remove this variable in this PR... |
@ramondeklein please send it separately, this PR can be merged as is. |
No description provided.